[webkit-reviews] review denied: [Bug 73858] [chromium] Set opaque() for VideoLayerChromium : [Attachment 118082] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Dana Jansens
<danakj at chromium.org>'s request for review:
Bug 73858: [chromium] Set opaque() for VideoLayerChromium
https://bugs.webkit.org/show_bug.cgi?id=73858

Attachment 118082: Patch
https://bugs.webkit.org/attachment.cgi?id=118082&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=118082&action=review


> Source/WebKit/chromium/src/WebMediaPlayerClientImpl.cpp:573
> +static bool frameFormatOpaque(WebVideoFrame::Format format)

nit: please do not put global functions in the middle of a string
of class member function definitions.  please move global functions
to the top of the source file.

nit: the name "frameFormatOpaque" could be improved.  it seems like
this function is trying to ask a question, so it should probably be
phrased in the form of a question.  how about "isFormatOpaque" or
"isVideoFrameFormatOpaque"?