[webkit-reviews] review denied: [Bug 70556] [Chromium] Plumb DPI info into PlatformScreen : [Attachment 118107] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Fady Samuel
<fsamuel at chromium.org>'s request for review:
Bug 70556: [Chromium] Plumb DPI info into PlatformScreen
https://bugs.webkit.org/show_bug.cgi?id=70556

Attachment 118107: Patch
https://bugs.webkit.org/attachment.cgi?id=118107&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=118107&action=review


> Source/WebCore/page/Screen.h:47
> +	   unsigned horizontalDpi() const;

webkit style would be horizontalDPI and verticalDPI

> Source/WebKit/chromium/src/x11/WebScreenInfoFactory.cpp:47
> +    const float InchesPerMillimeter = 25.4;

nit: inchesPerMillimeter