[webkit-reviews] review granted: [Bug 73947] GC zapping logic could benefit from some more assertions : [Attachment 118103] the patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 6 13:45:36 PST 2011


Gavin Barraclough <barraclough at apple.com> has granted Filip Pizlo
<fpizlo at apple.com>'s request for review:
Bug 73947: GC zapping logic could benefit from some more assertions
https://bugs.webkit.org/show_bug.cgi?id=73947

Attachment 118103: the patch
https://bugs.webkit.org/attachment.cgi?id=118103&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=118103&action=review


> Source/JavaScriptCore/heap/MarkedBlock.h:293
> +	       }

This could be:
    ASSERT(!isZapped(cell) || !m_marks.get(atomNumber(cell)));
    return !isZapped(cell);


More information about the webkit-reviews mailing list