[webkit-reviews] review granted: [Bug 71869] [Chromium] Implement tile-sized painting using SkPicture : [Attachment 117961] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 6 13:07:33 PST 2011


James Robinson <jamesr at chromium.org> has granted David Reveman
<reveman at chromium.org>'s request for review:
Bug 71869: [Chromium] Implement tile-sized painting using SkPicture
https://bugs.webkit.org/show_bug.cgi?id=71869

Attachment 117961: Patch
https://bugs.webkit.org/attachment.cgi?id=117961&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=117961&action=review


This looks great, let's do it!

>
Source/WebCore/platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpda
ter.h:66
> +    explicit
BitmapSkPictureCanvasLayerTextureUpdater(PassOwnPtr<LayerPainterChromium>, bool
useMapTexSubImage);

you don't need 'explicit' for 2-arg c'tors


More information about the webkit-reviews mailing list