[webkit-reviews] review denied: [Bug 73869] BlackBerry PlayBook doesn't sniff mime types : [Attachment 118092] cleaned up some style, added changelog entry

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 6 12:41:53 PST 2011


Rob Buis <rwlbuis at gmail.com> has denied tabbott at rim.com's request for review:
Bug 73869: BlackBerry PlayBook doesn't sniff mime types
https://bugs.webkit.org/show_bug.cgi?id=73869

Attachment 118092: cleaned up some style, added changelog entry
https://bugs.webkit.org/attachment.cgi?id=118092&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=118092&action=review


The code looks great to me, but ChangeLog does not follow the required format.
Probably last round but r1 for now.

> Source/WebCore/ChangeLog:19
> +

The ChangeLog is not quite right, it goes:

bug title
bug url

reviewed by

Description of the solution

Tests, or why there are no tests.


More information about the webkit-reviews mailing list