[webkit-reviews] review granted: [Bug 72748] NRWT fails on unreleased versions of Mac OS X : [Attachment 118080] Patch

[bugzilla-daemon at webkit.org]

Dirk Pranke <dpranke at chromium.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 72748: NRWT fails on unreleased versions of Mac OS X
https://bugs.webkit.org/show_bug.cgi?id=72748

Attachment 118080: Patch
https://bugs.webkit.org/attachment.cgi?id=118080&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=118080&action=review


> Tools/Scripts/webkitpy/layout_tests/port/webkit.py:354
> +		   _log.debug("Skipped does not exist: %s" % filename)

It seems like skipped_file_search_paths() shouldn't be returning a directory
that doesn't exist for mac-future. Can you add a fixme or file a separate bug
for that? 

As an aside, I'm not sure what the difference between self.port_name and
self.name() is supposed to be; I can't remember if I added that or someone else
did, but it seems like the two names are confusing so we should probably clean
that up at some point as well.