[webkit-reviews] review granted: [Bug 73937] [chromium] Guard access to WebKitPlatformSupport::currentThread with a null check : [Attachment 118076] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 6 11:33:20 PST 2011


Adam Barth <abarth at webkit.org> has granted Adam Klein <adamk at chromium.org>'s
request for review:
Bug 73937: [chromium] Guard access to WebKitPlatformSupport::currentThread with
a null check
https://bugs.webkit.org/show_bug.cgi?id=73937

Attachment 118076: Patch
https://bugs.webkit.org/attachment.cgi?id=118076&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=118076&action=review


> Source/WebKit/chromium/ChangeLog:10
> +	   Though |currentThread| is never null in production code, it is null
in
> +	   unit tests (such as Chromium's unit_tests) that call
WebKit::initialize()
> +	   without first constructing a MessageLoop.

Can you add this comment to the code as well?  We don't want folks cargo-cult
copying this null check.


More information about the webkit-reviews mailing list