[webkit-reviews] review granted: [Bug 73924] [EFL] Do not lose message flags when soup resources are converted. : [Attachment 118055] Add bug number to ChangeLog

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 6 11:22:45 PST 2011

Gustavo Noronha (kov) <gns at gnome.org> has granted Raphael Kubo da Costa
<kubo at profusion.mobi>'s request for review:
Bug 73924: [EFL] Do not lose message flags when soup resources are converted.

Attachment 118055: Add bug number to ChangeLog

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=118055&action=review

> Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp:239
> +void FrameLoaderClientEfl::dispatchDidReceiveResponse(DocumentLoader*
loader, unsigned long, const ResourceResponse& response)
>  {
> +#if USE(SOUP)
> +    // Update our knowledge of request soup flags - some are only set
> +    // after the request is done.
> +    loader->request().setSoupMessageFlags(response.soupMessageFlags());
> +#endif

If you want your build to be really tidy in the non-soup case you should
probably have UNUSED_PARAM(loader); in an #else block here, looks good

More information about the webkit-reviews mailing list