[webkit-reviews] review denied: [Bug 73930] Web Inspector: introduce a memory agent stub. : [Attachment 118069] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 6 10:42:40 PST 2011


Timothy Hatcher <timothy at apple.com> has denied Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 73930: Web Inspector: introduce a memory agent stub.
https://bugs.webkit.org/show_bug.cgi?id=73930

Attachment 118069: Patch
https://bugs.webkit.org/attachment.cgi?id=118069&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=118069&action=review


> Source/WebCore/bindings/js/ScriptProfiler.h:61
> +    static unsigned nodeCount() { return 0; }

Where is the JSC implementation or the bug? Please add a FIXME to the code
where JSC just returns 0.


More information about the webkit-reviews mailing list