[webkit-reviews] review denied: [Bug 73869] BlackBerry PlayBook doesn't sniff mime types : [Attachment 118046] hook up MIMESniffer

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has denied tabbott at rim.com's request for review:
Bug 73869: BlackBerry PlayBook doesn't sniff mime types
https://bugs.webkit.org/show_bug.cgi?id=73869

Attachment 118046: hook up MIMESniffer
https://bugs.webkit.org/attachment.cgi?id=118046&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=118046&action=review


This really needs a ChangeLog! Looks quite good otherwise.

> Source/WebCore/platform/network/MIMESniffing.cpp:28
> +using std::strlen;

This should not be needed. Also it may be better to do this in a seperate bug.

> Source/WebCore/platform/network/blackberry/NetworkJob.cpp:364
> +	       if (pos != -1) {

pos variable can be introduced in the if

> Source/WebCore/platform/network/blackberry/NetworkJob.cpp:374
> +	       const char* type = sniffer.sniff(buf, len);

Can be included in if.

> Source/WebCore/platform/network/blackberry/NetworkJob.cpp:376
> +		m_sniffedMimeType = WTF::String(type);

Wrong indentation.