[webkit-reviews] review granted: [Bug 45666] [Qt] Click's count is limited to three continuous click : [Attachment 118049] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Hugo Parente Lima
<hugo.lima at openbossa.org>'s request for review:
Bug 45666: [Qt]  Click's count is limited to three continuous click
https://bugs.webkit.org/show_bug.cgi?id=45666

Attachment 118049: Patch
https://bugs.webkit.org/attachment.cgi?id=118049&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=118049&action=review


> Source/WebKit2/UIProcess/qt/QtWebPageEventHandler.cpp:162
> +    if (m_clickTimer.isActive()
> +	       && m_previousClickButton == ev->button()
> +	       && (ev->pos() - m_lastClick).manhattanLength() <
qApp->styleHints()->startDragDistance()) {

wrong indentation according to the style guide... (hint, it is indented too
much)

> Tools/ChangeLog:8
> +	   Update m_time at every call to leapForward, so dbl clicks

write out "double"