[webkit-reviews] review denied: [Bug 73563] use NOMINMAX instead of #define min min : [Attachment 117817] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Dec 6 06:36:24 PST 2011
Adam Roben (:aroben) <aroben at apple.com> has denied Paul <harris.pc at gmail.com>'s
request for review:
Bug 73563: use NOMINMAX instead of #define min min
https://bugs.webkit.org/show_bug.cgi?id=73563
Attachment 117817: Patch
https://bugs.webkit.org/attachment.cgi?id=117817&action=review
------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
I agree this is better than #define min min!
I think an even better way to do this these days would be to put this in
WebKitLibraries/win/tools/vsprops/common.vsprops. All projects inherit settings
from there.
More information about the webkit-reviews
mailing list