[webkit-reviews] review denied: [Bug 73190] <style scoped>: Implement scoped stylesheets and basic application : [Attachment 117130] Patch (requires 67718, 67790)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 6 06:33:05 PST 2011

Antti Koivisto <koivisto at iki.fi> has denied Roland Steiner
<rolandsteiner at chromium.org>'s request for review:
Bug 73190: <style scoped>: Implement scoped stylesheets and basic application

Attachment 117130: Patch (requires 67718, 67790)

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
It is going to the right direction but I'd still like to see more of my
comments addressed. CSSStyleSelector::matchAuthorRules() code for getting the
scoped RuleSets should be factored into a function. It would also be nice if
the scoping element stack would point to the RuleSets directly instead of
inderectly via element and a hash lookip (though it can be done later too).
ScopedRuleSets class still doesn't really justify its existence etc.

More information about the webkit-reviews mailing list