[webkit-reviews] review granted: [Bug 73319] [GTK] Initial implementation of Accelerated Compositing using Clutter : [Attachment 117891] Proposed Patch7

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted Joone Hur
<joone.hur at collabora.co.uk>'s request for review:
Bug 73319: [GTK] Initial implementation of Accelerated Compositing using
Clutter
https://bugs.webkit.org/show_bug.cgi?id=73319

Attachment 117891: Proposed Patch7
https://bugs.webkit.org/attachment.cgi?id=117891&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=117891&action=review


Please fix those comments before landing!

> Source/WebCore/GNUmakefile.am:580
> +	-I$(srcdir)/Source/WebCore/platform/clutter

Missing a \

> Source/WebKit/gtk/webkit/webkitwebview.cpp:4913
> +	  
core(webView)->mainFrame()->view()->syncCompositingStateIncludingSubframes();

Don't we need to call this also after adding the new layer to the stage?

> Source/WebKit/gtk/webkit/webkitwebview.cpp:4949
> +static gboolean webViewSyncLayers(gpointer data)
> +{
> +    WebKitWebView* webView = WEBKIT_WEB_VIEW(data);
> +   
core(webView)->mainFrame()->view()->syncCompositingStateIncludingSubframes();
> +
> +    return FALSE;
>  }

Maybe wrap this in #if USE(CLUTTER) so that it won't give us warnings when
building without.