[webkit-reviews] review granted: [Bug 73900] Web Inspector: [TextPrompt] Autocomplete improperly determines user input : [Attachment 118022] [PATCH] Comments addressed

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 73900: Web Inspector: [TextPrompt] Autocomplete improperly determines user
input
https://bugs.webkit.org/show_bug.cgi?id=73900

Attachment 118022: [PATCH] Comments addressed
https://bugs.webkit.org/attachment.cgi?id=118022&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=118022&action=review


> Source/WebCore/inspector/front-end/TextPrompt.js:329
> +	   this._autocompleteRequestForced = force || false;

Please rename _autocompleteRequestForced to something more appropriate that
would reflect that it can have one of three states.

> Source/WebCore/inspector/front-end/TextPrompt.js:330
> +	   return;

Remove this line.