[webkit-reviews] review requested: [Bug 71968] Implement URL API : [Attachment 118024] Patch

[bugzilla-daemon at webkit.org]

Kaustubh Atrawalkar <kaustubh at motorola.com> has asked  for review:
Bug 71968: Implement URL API
https://bugs.webkit.org/show_bug.cgi?id=71968

Attachment 118024: Patch
https://bugs.webkit.org/attachment.cgi?id=118024&action=review

------- Additional Comments from Kaustubh Atrawalkar <kaustubh at motorola.com>
Tried to get the patch working somehow. Not sure if all correct yet. Erik, need
some assistance in the patch. May be u can review and let me know missing
parts. I found the problem in having "static" keyword before "[Conditional]".
Its because there is function overloading in the idl file. When i removed one
of them (MediaStream parameter API) it was building fine. But in normal case i
get errors - 

DerivedSources/WebCore/JSDOMURL.cpp:554:1: error: stray ‘#’ in program
DerivedSources/WebCore/JSDOMURL.cpp:567:2: error: #endif without #if
DerivedSources/WebCore/JSDOMURL.cpp:569:1: error: stray ‘#’ in program
DerivedSources/WebCore/JSDOMURL.cpp:593:2: error: #endif without #if

This is bcoz it creates two separate static functions in JSDOMURL.cpp as - 
static EncodedJSValue JSC_HOST_CALL
jsDOMURLConstructorFunctionCreateObjectURL1(ExecState* exec)
static EncodedJSValue JSC_HOST_CALL
jsDOMURLConstructorFunctionCreateObjectURL2(ExecState* exec)

one for MediaStream & one for Blob.