[webkit-reviews] review denied: [Bug 73511] Internals should have a method to return the max sequence number of spellcheck request. : [Attachment 118005] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 6 03:58:08 PST 2011


MORITA Hajime <morrita at google.com> has denied Shinya Kawanaka
<shinyak at google.com>'s request for review:
Bug 73511: Internals should have a method to return the max sequence number of
spellcheck request.
https://bugs.webkit.org/show_bug.cgi?id=73511

Attachment 118005: Patch
https://bugs.webkit.org/attachment.cgi?id=118005&action=review

------- Additional Comments from MORITA Hajime <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=118005&action=review


Basically looks nice. I pointed some nits.

> Source/WebCore/testing/Internals.cpp:624
> +    if (!document || !document->frame() || !document->frame()->editor() ||
!document->frame()->editor()->spellChecker()) {

Could you add a getter for spellchecker like Internals::spellchecker()?

> LayoutTests/ChangeLog:8
> +	   Tests to check internals.lastSpellCheckRequestSequence and
internals.lastSpellCheckProcessedSequence.

"Added tests"?

> LayoutTests/ChangeLog:12
> +

I guess we need to skip on some ports. You will know which ports do ;-)

> LayoutTests/editing/spelling/spellcheck-sequencenum.html:111
> +	       testPassed("SpellCheck sequence seems work correctly.");

"seems working"?


More information about the webkit-reviews mailing list