[webkit-reviews] review granted: [Bug 73626] Web Inspector: [Audits] Implement "Stop" button and progress bar instead of spinner. : [Attachment 117866] [PATCH] Comment addressed

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 73626: Web Inspector: [Audits] Implement "Stop" button and progress bar
instead of spinner.
https://bugs.webkit.org/show_bug.cgi?id=73626

Attachment 117866: [PATCH] Comment addressed
https://bugs.webkit.org/attachment.cgi?id=117866&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=117866&action=review


> Source/WebCore/inspector/front-end/AuditLauncherView.js:128
> +	       var childNodes = this._categoriesElement.childNodes;

Remove this line, childNodes is unused.

> Source/WebCore/inspector/front-end/AuditsPanel.js:506
> +	   if (this.canceled || this.indeterminate || this.isDone())

Be consistent in naming either isCanceled or done().