[webkit-reviews] review granted: [Bug 73761] Use HashMap<OwnPtr> for EventListenerMap's internal map. : [Attachment 117781] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Andreas Kling
<kling at webkit.org>'s request for review:
Bug 73761: Use HashMap<OwnPtr> for EventListenerMap's internal map.
https://bugs.webkit.org/show_bug.cgi?id=73761

Attachment 117781: Patch
https://bugs.webkit.org/attachment.cgi?id=117781&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=117781&action=review


Nice

> Source/WebCore/dom/EventListenerMap.cpp:-79
> -    if (m_hashMap) {
> -	   deleteAllValues(*m_hashMap);
> +    if (m_hashMap)
>	   m_hashMap.clear();
> -    } else {

Here your patch does two things: fix the style && change the code.
You should make a separate patch for the style fix, then apply your hash map
fix... :-D