[webkit-reviews] review denied: [Bug 73889] TextCheckingParagraph::offsetTo should not have side effect. : [Attachment 117994] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Dec 5 23:09:03 PST 2011
MORITA Hajime <morrita at google.com> has denied Shinya Kawanaka
<shinyak at google.com>'s request for review:
Bug 73889: TextCheckingParagraph::offsetTo should not have side effect.
https://bugs.webkit.org/show_bug.cgi?id=73889
Attachment 117994: Patch
https://bugs.webkit.org/attachment.cgi?id=117994&action=review
------- Additional Comments from MORITA Hajime <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=117994&action=review
> Source/WebCore/editing/TextCheckingHelper.cpp:161
> + if (ec)
I guess this never fail. you can use ASSERT_NO_EXCEPTION.
More information about the webkit-reviews
mailing list