[webkit-reviews] review denied: [Bug 72715] Implement AccessKeyLabel attribute. : [Attachment 117549] updated_patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Dec 5 21:19:40 PST 2011
Alexey Proskuryakov <ap at webkit.org> has denied review:
Bug 72715: Implement AccessKeyLabel attribute.
https://bugs.webkit.org/show_bug.cgi?id=72715
Attachment 117549: updated_patch
https://bugs.webkit.org/attachment.cgi?id=117549&action=review
------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
Ah right. You can do something like this for cross-platofrm results:
if (navigator.userAgent.search(/\bMac OS X\b/) != -1)
expected = "⌥A";
else
expected = "Alt+A";
shouldBe("input_item.accessKeyLabel",'expected');
Looking at this part of the test closely, I noticed that you're missing quotes
in Mac case (evaluating 'ââ¥A' will give an error).
More information about the webkit-reviews
mailing list