[webkit-reviews] review denied: [Bug 73817] [TexMap][QT] TexMap does not draw the border of media and webgl elements. : [Attachment 117964] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Dec 5 17:58:11 PST 2011
Noam Rosenthal <noam.rosenthal at nokia.com> has denied Huang Dongsung
<luxtella at company100.net>'s request for review:
Bug 73817: [TexMap][QT] TexMap does not draw the border of media and webgl
elements.
https://bugs.webkit.org/show_bug.cgi?id=73817
Attachment 117964: patch
https://bugs.webkit.org/attachment.cgi?id=117964&action=review
------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=117964&action=review
You can probably get the same result without redundant updates by getting rid
of some code :)
> Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:73
> + m_pendingContent.needsDisplay = true;
You can probably remove these two lines; otherwise you're causing unnecessary
updates.
> Source/WebCore/platform/graphics/texmap/TextureMapperNode.cpp:301
> - if (m_currentContent.contentType == MediaContentType)
> + if (m_currentContent.contentType == MediaContentType &&
!m_currentContent.needsDisplay)
> return;
The code would probably work just the same if you remove these lines from the
code altogether.
More information about the webkit-reviews
mailing list