[webkit-reviews] review granted: [Bug 73878] webkit.py: Really fix the printing of StringImpl now that 8 bit strings are present : [Attachment 117956] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Raphael Kubo da Costa
<kubo at profusion.mobi>'s request for review:
Bug 73878: webkit.py: Really fix the printing of StringImpl now that 8 bit
strings are present
https://bugs.webkit.org/show_bug.cgi?id=73878

Attachment 117956: Patch
https://bugs.webkit.org/attachment.cgi?id=117956&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=117956&action=review


> Tools/gdb/webkit.py:112
> +	   return self.val['m_impl']['m_ptr']['m_hashAndFlags'] & \
> +		  self.val['m_impl']['m_ptr']['s_hashFlag8BitBuffer']

The line wrapping is wrong (incorrect indention), but I would either just make
this a single line.

> Tools/gdb/webkit.py:136
> +	   return self.val['m_impl']['m_ptr']['m_hashAndFlags'] & \
> +		  self.val['m_impl']['m_ptr']['s_hashFlag8BitBuffer']

Ditto.