[webkit-reviews] review granted: [Bug 73847] NRWT creates too many workers on RAM-limited machines : [Attachment 117944] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 5 15:45:06 PST 2011

Dirk Pranke <dpranke at chromium.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 73847: NRWT creates too many workers on RAM-limited machines

Attachment 117944: Patch

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=117944&action=review

>>> Tools/Scripts/webkitpy/layout_tests/port/base.py:177
>>> +	     return cpu_count
>> I'm not sure zero should be a legal value here, so maybe you should return
at least 1? If it is zero (essentially saying we need at least 300MB to run),
there should probably at least be a check in run_webkit_tests:
_set_up_derived_options() to handle zero cleanly and bail out.
> This is no different from setting --child-count=0 directly.  I think that's
out of scope of this change.

I disagree, in the sense that there was no way default_child_processes() could
return 0 before, and now it can, potentially breaking things down the road.
That said, it'll probably never come up in practice. Up to you ...

More information about the webkit-reviews mailing list