[webkit-reviews] review denied: [Bug 73847] NRWT creates too many workers on RAM-limited machines : [Attachment 117944] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 5 15:22:51 PST 2011

Dirk Pranke <dpranke at chromium.org> has denied Eric Seidel <eric at webkit.org>'s
request for review:
Bug 73847: NRWT creates too many workers on RAM-limited machines

Attachment 117944: Patch

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=117944&action=review

> Tools/Scripts/run-webkit-tests:79
> +    return !isQt();

Are we sure that it was a RAM issue and not something else?

Also, in the future I'd probably change the defaults in port/mac.py et al.
rather than duplicating the logic here in Perl.

> Tools/Scripts/webkitpy/layout_tests/port/base.py:177
> +	   return cpu_count

I'm not sure zero should be a legal value here, so maybe you should return at
least 1? If it is zero (essentially saying we need at least 300MB to run),
there should probably at least be a check in run_webkit_tests:
_set_up_derived_options() to handle zero cleanly and bail out.

More information about the webkit-reviews mailing list