[webkit-reviews] review requested: [Bug 73858] [chromium] Set opaque() for VideoLayerChromium : [Attachment 117933] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 5 13:32:23 PST 2011


Dana Jansens <danakj at chromium.org> has asked  for review:
Bug 73858: [chromium] Set opaque() for VideoLayerChromium
https://bugs.webkit.org/show_bug.cgi?id=73858

Attachment 117933: Patch
https://bugs.webkit.org/attachment.cgi?id=117933&action=review

------- Additional Comments from Dana Jansens <danakj at chromium.org>
Two questions here.

1. Should WebVideoFrame::isFormatOpaque() be virtual?

2. Should the "if (layer->opaque() != opaque)" test be done in LC::setOpaque()
or in the caller of the function?


More information about the webkit-reviews mailing list