[webkit-reviews] review granted: [Bug 73854] small refactor of RenderFlexibleBox : [Attachment 117918] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 5 12:36:14 PST 2011


Darin Adler <darin at apple.com> has granted Tony Chang <tony at chromium.org>'s
request for review:
Bug 73854: small refactor of RenderFlexibleBox
https://bugs.webkit.org/show_bug.cgi?id=73854

Attachment 117918: Patch
https://bugs.webkit.org/attachment.cgi?id=117918&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=117918&action=review


> Source/WebCore/rendering/RenderFlexibleBox.cpp:627
> +	   IntPoint childLocation(shouldFlipMainAxis ? totalMainExtent -
mainAxisOffset - childMainExtent : mainAxisOffset,
> +				  crossAxisOffset +
flowAwareMarginBeforeForChild(child));

WebKit formatting rules forbid this kind of lining up since it’s not
renaming-infriendly.


More information about the webkit-reviews mailing list