[webkit-reviews] review denied: [Bug 73489] Add fling animation support to ScrollAnimatorNone : [Attachment 117499] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has denied vollick at chromium.org's request for
review:
Bug 73489: Add fling animation support to ScrollAnimatorNone
https://bugs.webkit.org/show_bug.cgi?id=73489

Attachment 117499: Patch
https://bugs.webkit.org/attachment.cgi?id=117499&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=117499&action=review


The code changes look OK to me. One procedural issue and one minor nit.

> Source/WebCore/ChangeLog:8
> +	   No new tests. (OOPS!)

This particular OOPS needs to be resolved. You really should add tests for this
change. Talk with wjmaclean about how his recent ScrollAnimatorNone changes
were tested in DumpRenderTree. If it's highly impractical to test these changes
you can explain why and remove the OOPS, but I would discourage doing this.

> Source/WebCore/platform/ScrollAnimatorNone.h:3
> + *

Try to avoid spurious whitespace changes.