[webkit-reviews] review granted: [Bug 72964] [chromium] Set opaque flag for ImageLayerChromium : [Attachment 117911] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 5 12:12:22 PST 2011


James Robinson <jamesr at chromium.org> has granted Dana Jansens
<danakj at chromium.org>'s request for review:
Bug 72964: [chromium] Set opaque flag for ImageLayerChromium
https://bugs.webkit.org/show_bug.cgi?id=72964

Attachment 117911: Patch
https://bugs.webkit.org/attachment.cgi?id=117911&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=117911&action=review


Great! R=me

> Source/WebKit/chromium/tests/ImageLayerChromiumTest.cpp:56
> +    explicit TestImage(const IntSize& size, bool opaque)

nit: for the future, you don't need explicit for 2-arg c'tors. it doesn't
really hurt to have it in test code, though


More information about the webkit-reviews mailing list