[webkit-reviews] review denied: [Bug 73621] [chromium] Use ANGLE's texture_usage and texture_storage extensions when allocating compositor textures : [Attachment 117568] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has denied Vangelis Kokkevis
<vangelis at chromium.org>'s request for review:
Bug 73621: [chromium] Use ANGLE's texture_usage and texture_storage extensions
when allocating compositor textures
https://bugs.webkit.org/show_bug.cgi?id=73621

Attachment 117568: Patch
https://bugs.webkit.org/attachment.cgi?id=117568&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=117568&action=review


Looks good overall. One minor issue that will fix the build failure. Please
upload a revised patch and we can r+/cq+ it.

> Source/WebKit/chromium/public/platform/WebGraphicsContext3D.h:386
> +				    WGC3Dint width, WGC3Dint height) = 0;

Give this an empty body like the method above. That will fix the cr-linux build
failure. I gather from fishd@ that this is OK to leave in essentially
permanently.