[webkit-reviews] review denied: [Bug 73176] Add 'isProtocolHandlerRegistered' and 'unregisterProtocolHandler'. : [Attachment 117856] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Dongwoo Joshua Im
<dw.im at samsung.com>'s request for review:
Bug 73176: Add 'isProtocolHandlerRegistered' and 'unregisterProtocolHandler'.
https://bugs.webkit.org/show_bug.cgi?id=73176

Attachment 117856: Patch
https://bugs.webkit.org/attachment.cgi?id=117856&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=117856&action=review


This patch has a bunch of unrelated changes.

> Source/WebCore/page/Chrome.cpp:366
> +String Chrome::isProtocolHandlerRegistered(const String& scheme, const
String& baseURL, const String& url)
> +{
> +    return m_client->isProtocolHandlerRegistered(scheme, baseURL, url);
> +}
> +void Chrome::unregisterProtocolHandler(const String& scheme, const String&
baseURL, const String& url)
> +{
> +    m_client->unregisterProtocolHandler(scheme, baseURL, url);
> +}

Functions should have blank lines between them.

> Source/WebCore/page/Navigator.cpp:290
> +    String declined = String("declined");

You don't need to call the string constructor explicitly.

> Source/WebCore/page/Navigator.cpp:297
> +    if (!document)
> +	   return declined;

This can never occur.

> Source/WebCore/page/Navigator.cpp:299
> +    String baseURL = document->baseURL().baseAsString();

Why the base URL?

> Source/WebCore/page/Navigator.cpp:309
> +    Page* page = m_frame->page();
> +    if (!page)
> +	   return declined;

Why not check for this at the top?