[webkit-reviews] review granted: [Bug 73779] Move code for connections to/from the UIProcess/WebProcess into WebConnection subclasses : [Attachment 117807] Patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 73779: Move code for connections to/from the UIProcess/WebProcess into
WebConnection subclasses
https://bugs.webkit.org/show_bug.cgi?id=73779

Attachment 117807: Patch
https://bugs.webkit.org/attachment.cgi?id=117807&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=117807&action=review


> Source/WebKit2/UIProcess/WebConnectionToWebProcess.cpp:97
> +    // This will invalidate the CoreIPC::Connection and the WebProcessProxy
pointer
> +    // so we should be careful not to use them after this call.

Please clarify that it's the member variable that will be invalidated.

>> Source/WebKit2/WebProcess/WebProcess.h:40
>> +#include "WebConnectionToUIProcess.h"
> 
> Alphabetical sorting problem.  [build/include_order] [4]

Please fix this.