[webkit-reviews] review denied: [Bug 73632] Upstream 7 files into WebCore/platform/blackberry : [Attachment 117854] Patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has denied Mary Wu <mary.wu at torchmobile.com.cn>'s
request for review:
Bug 73632: Upstream 7 files into WebCore/platform/blackberry
https://bugs.webkit.org/show_bug.cgi?id=73632

Attachment 117854: Patch
https://bugs.webkit.org/attachment.cgi?id=117854&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=117854&action=review


Looks good, nearly there, could be improved a bit, so r-.

> Source/WebCore/platform/blackberry/PopupMenuBlackBerry.h:23
> +#include "PopupMenuClient.h"

I think a forward reference for PopupMenuClient should do.

> Source/WebCore/platform/blackberry/ScrollbarThemeBlackBerry.cpp:29
> +    static ScrollbarTheme theme;

Can DEFINE_STATIC_LOCAL be used here?