[webkit-reviews] review granted: [Bug 71724] Optimize double border and outline rendering to avoid transparency layers : [Attachment 117837] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted David Barr
<davidbarr at chromium.org>'s request for review:
Bug 71724: Optimize double border and outline rendering to avoid transparency
layers
https://bugs.webkit.org/show_bug.cgi?id=71724

Attachment 117837: Patch
https://bugs.webkit.org/attachment.cgi?id=117837&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=117837&action=review


> Source/WebCore/rendering/RenderBoxModelObject.cpp:1664
>      bool haveAllSolidEdges = true;
> +    bool haveAllDoubleEdges = true;

Another way to do this would be to add allEdgesShareStyle, like
allEdgesShareColor.

> Source/WebCore/rendering/RenderBoxModelObject.cpp:1718
> +		   LayoutRect innerThirdRect = outerThird.rect();
> +		   LayoutRect outerThirdRect = outerThird.rect();

Using outerThird.rect for both is intentional?