[webkit-reviews] review denied: [Bug 73754] Avoid calling calculateRects in RenderLayer::paintLayer when the rectangles are not needed : [Attachment 117774] Proposed change: limit the call to calculateRects for when we need it.

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 73754: Avoid calling calculateRects in RenderLayer::paintLayer when the
rectangles are not needed
https://bugs.webkit.org/show_bug.cgi?id=73754

Attachment 117774: Proposed change: limit the call to calculateRects for when
we need it.
https://bugs.webkit.org/attachment.cgi?id=117774&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=117774&action=review


> Source/WebCore/rendering/RenderLayer.cpp:2807
> +    if (isSelfPaintingLayer && !paintingOverlayScrollbars)

Can you not test m_hasVisibleContent here too?

The different tests in the different places are a bit messy. I'd prefer the
logic be cleaned up.

You should also look at RenderLayerBacking::paintLayer() which shares some of
the same code.

> Source/WebCore/rendering/RenderLayer.cpp:2876
> +    // FIXME: Shouldn't we check against shouldPaint here too to match the
other branches?

I think you should try it and see if any pixel test start to fail.