[webkit-reviews] review denied: [Bug 73817] [TexMap][QT] TexMap does not draw the border of media and webgl elements. : [Attachment 117865] patch

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam.rosenthal at nokia.com> has denied Huang Dongsung
<luxtella at company100.net>'s request for review:
Bug 73817: [TexMap][QT] TexMap does not draw the border of media and webgl
elements.
https://bugs.webkit.org/show_bug.cgi?id=73817

Attachment 117865: patch
https://bugs.webkit.org/attachment.cgi?id=117865&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=117865&action=review


> Source/WebCore/ChangeLog:9
> +	   GraphicsContext3D only draws the content, not CSS box border and
TexMap only
> +	   composited the platformLayer of media and webgl elements.
> +	   It causes that TexMap did not render the border of following layout
test.
> +	   LayoutTests/compositing/webgl/webgl-reflection.html

Let's rewrite this...
"GraphicsContext3D only draws the content of the WebGL canvas, not the
additional CSS such as the borders. TextureMapper should render the content of
a media/webgl layer before drawing the actual canvas."
This makes LayoutTests/compositing/webgl/webgl-reflection.html work.

> Source/WebCore/platform/graphics/texmap/TextureMapperNode.cpp:318
> +	   if (m_currentContent.contentType == MediaContentType && !needsReset)

> +	       continue;

Doesn't seem correct. This means that we ignore partial-updates for WebGL/media
layers.