[webkit-reviews] review denied: [Bug 73814] [Qt] Remove redundant m_glWidget->makeCurrent() calls in GraphicsContext3DQt. : [Attachment 117863] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Dec 5 08:13:12 PST 2011
Noam Rosenthal <noam.rosenthal at nokia.com> has denied Huang Dongsung
<luxtella at company100.net>'s request for review:
Bug 73814: [Qt] Remove redundant m_glWidget->makeCurrent() calls in
GraphicsContext3DQt.
https://bugs.webkit.org/show_bug.cgi?id=73814
Attachment 117863: patch
https://bugs.webkit.org/attachment.cgi?id=117863&action=review
------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=117863&action=review
Good patch, insufficient ChangeLog.
> Source/WebCore/ChangeLog:8
> + Reviewed by NOBODY (OOPS!).
Insufficient Changelog. Please describe that you've moved all the calls into
makeContextCurrent.
More information about the webkit-reviews
mailing list