[webkit-reviews] review denied: [Bug 73612] Upstream WebKit/blackberry/WebCoreSupport/AboutData.{h, cpp} : [Attachment 117849] Patch v3

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has denied Leo Yang
<leo.yang at torchmobile.com.cn>'s request for review:
Bug 73612: Upstream WebKit/blackberry/WebCoreSupport/AboutData.{h, cpp}
https://bugs.webkit.org/show_bug.cgi?id=73612

Attachment 117849: Patch v3
https://bugs.webkit.org/attachment.cgi?id=117849&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=117849&action=review


I think another round is needed, to cleanup the code some more. Good job on
figuring out what Features got dropped and added.

> Source/WebKit/blackberry/WebCoreSupport/AboutData.cpp:2126
> +    "YARR_JIT_DEBUG");

The features seem to match now AFAICS. But looking at this repeated structure,
this seems to cry out for a macro :)

> Source/WebKit/blackberry/WebCoreSupport/AboutData.cpp:2143
> +static const int s_kilobyte = 1024;

Should use DEFINE_STATIC_LOCAL within cacheTypeStatisticToHTMLTr

> Source/WebKit/blackberry/WebCoreSupport/AboutData.cpp:2153
> +    return tr;

Maybe does not need the temp var.