[webkit-reviews] review denied: [Bug 73628] Refactoring: Editor::markAllMisspellingsAndBadGrammarInRanges should be refactored. : [Attachment 117855] Patch

[bugzilla-daemon at webkit.org]

MORITA Hajime <morrita at google.com> has denied Shinya Kawanaka
<shinyak at google.com>'s request for review:
Bug 73628: Refactoring: Editor::markAllMisspellingsAndBadGrammarInRanges should
be refactored.
https://bugs.webkit.org/show_bug.cgi?id=73628

Attachment 117855: Patch
https://bugs.webkit.org/attachment.cgi?id=117855&action=review

------- Additional Comments from MORITA Hajime <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=117855&action=review


Basically looks nice. There are only a few nits.

> Source/WebCore/editing/Editor.cpp:2045
> +    ExceptionCode ec = 0;

It's good opportunity to eliminate this. You can use ASSERT_NO_EXCEPTION.

> Source/WebCore/editing/Editor.h:39
> +#include "TextCheckingHelper.h"

I really want hide this in .cpp file.

> Source/WebCore/editing/Editor.h:408
> +    void markAndReplaceFor(TextCheckingTypeMask, const
Vector<TextCheckingResult>&, TextCheckingParagraph spellingParagraph,
TextCheckingParagraph grammarParagraph);

Is it possible to pass TextCheckingParagraph as a reference or a pointer?