[webkit-reviews] review denied: [Bug 73632] Upstream 7 files into WebCore/platform/blackberry : [Attachment 117822] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has denied Mary Wu
<mary.wu at torchmobile.com.cn>'s request for review:
Bug 73632: Upstream 7 files into WebCore/platform/blackberry
https://bugs.webkit.org/show_bug.cgi?id=73632

Attachment 117822: Patch
https://bugs.webkit.org/attachment.cgi?id=117822&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=117822&action=review


> Source/WebCore/platform/blackberry/PopupMenuBlackBerry.cpp:33
> +void PopupMenuBlackBerry::show(const IntRect& r, FrameView* v, int index)

All of these parameters are unused. Either we need to use UNUSED_PARAM() or we
need to omit them from the signature here or this may cause unused variable
warnings depending on the compiler warning level.

> Source/WebCore/platform/blackberry/ScrollViewBlackBerry.cpp:22
> +namespace WebCore {

Why do we need to commit this almost empty file?

> Source/WebCore/platform/blackberry/ScrollbarBlackBerry.cpp:22
> +namespace WebCore {

Ditto.