[webkit-reviews] review denied: [Bug 73789] Need SSE optimization for SincResampler::Process() : [Attachment 117838] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has denied xingnan.wang at intel.com's
request for review:
Bug 73789: Need SSE optimization for SincResampler::Process()
https://bugs.webkit.org/show_bug.cgi?id=73789

Attachment 117838: Patch
https://bugs.webkit.org/attachment.cgi?id=117838&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=117838&action=review


> Source/WebCore/platform/audio/SincResampler.cpp:-249
> -	       // FIXME: add SIMD optimizations for the following. The scalar
code-path can probably also be optimized better.

This could be changed to
// FIXME: add ARM NEON optimizations for the following. The scalar code-path
can probably also be optimized better.
:)

> Source/WebCore/platform/audio/SincResampler.cpp:262
> +		   input = *inputP++;
> +		   sum1 += input * *k1;
> +		   sum2 += input * *k2;
> +		   ++k1;
> +		   ++k2;

You should put your code under the #define CONVOLVE_ONE_SAMPLE and use the
macro here.

> Source/WebCore/platform/audio/SincResampler.cpp:267
> +	       int group = n / 4;

Typically you can just compute the end pointer so you do not have to keep track
of that.

> Source/WebCore/platform/audio/SincResampler.cpp:355
> +		   input = *inputP++;
> +		   sum1 += input * *k1;
> +		   sum2 += input * *k2;
> +		   ++k1;
> +		   ++k2;

Same regarding CONVOLVE_ONE_SAMPLE.