[webkit-reviews] review denied: [Bug 72441]=?UTF-8?Q?=20Dynamically=20created=20ShadowRoot=20doesn=E2=80=99t=20suppress=20the=20rendering=20of=20light=20children=20?=: [Attachment 115524] suppress light children.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Dec 4 20:25:58 PST 2011


MORITA Hajime <morrita at google.com> has denied Hayato Ito
<hayato at chromium.org>'s request for review:
Bug 72441: Dynamically created ShadowRoot doesn’t suppress the rendering of
light children
https://bugs.webkit.org/show_bug.cgi?id=72441

Attachment 115524: suppress light children.
https://bugs.webkit.org/attachment.cgi?id=115524&action=review

------- Additional Comments from MORITA Hajime <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=115524&action=review


> Source/WebCore/dom/Element.cpp:1271
> +    }

I prefer just call reattach() here because some Element subclasses have child
attachment process and we need to preserve their customized behavior.
Maybe we need a lazy version of reattach().


More information about the webkit-reviews mailing list