[webkit-reviews] review granted: [Bug 73780] Convert JSClassRef to use HashMap<OwnPtr> : [Attachment 117808] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Dec 4 18:49:07 PST 2011


Andreas Kling <kling at webkit.org> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 73780: Convert JSClassRef to use HashMap<OwnPtr>
https://bugs.webkit.org/show_bug.cgi?id=73780

Attachment 117808: Patch
https://bugs.webkit.org/attachment.cgi?id=117808&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=117808&action=review


> Source/JavaScriptCore/API/JSClassRef.cpp:82
>		   // Use a local variable here to sidestep an RVCT compiler
bug.

Side-stepping RVCT bugs is not an issue anymore AFAIK.
Support for Symbian has been removed from WebKit trunk, and I believe it was
the only user of RVCT.
(This comment repeated for each occurrence of that workaround.)


More information about the webkit-reviews mailing list