[webkit-reviews] review denied: [Bug 73531] Make prepare-ChangeLog a Perl module : [Attachment 117371] Patch

[bugzilla-daemon at webkit.org]

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has denied Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 73531: Make prepare-ChangeLog a Perl module
https://bugs.webkit.org/show_bug.cgi?id=73531

Attachment 117371: Patch
https://bugs.webkit.org/attachment.cgi?id=117371&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
This patch tries to do too much at once.  If we're going to refactor
prepare-ChangeLog, we should do it in smaller steps (with unit tests written
for each smaller patch).

It would also be acceptable to change prepare-ChangeLog just enough to make it
possible to load the file as a module for unit testing (like run-leaks).  The
way you do this is (likely) to refactor away the use of the problematic global
variables.