[webkit-reviews] review denied: [Bug 73531] Make prepare-ChangeLog a Perl module : [Attachment 117371] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Dec 3 20:53:01 PST 2011

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has denied Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 73531: Make prepare-ChangeLog a Perl module

Attachment 117371: Patch

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
This patch tries to do too much at once.  If we're going to refactor
prepare-ChangeLog, we should do it in smaller steps (with unit tests written
for each smaller patch).

It would also be acceptable to change prepare-ChangeLog just enough to make it
possible to load the file as a module for unit testing (like run-leaks).  The
way you do this is (likely) to refactor away the use of the problematic global

More information about the webkit-reviews mailing list