[webkit-reviews] review granted: [Bug 73680] Convert isolate and plaintext tests to reftests : [Attachment 117671] converts the test

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 73680: Convert isolate and plaintext tests to reftests
https://bugs.webkit.org/show_bug.cgi?id=73680

Attachment 117671: converts the test
https://bugs.webkit.org/attachment.cgi?id=117671&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Is there a height limit on ref tests? Do they still work on content that is
very tall or very wide?

Removing the expected result lines (the “reference” ones) from the original of
the tests is OK for DumpRenderTree, but not so great for running the tests in
the browser and looking to see if they are working. For these sorts of tests,
I’d prefer to have the ref contain doubled versions of things and have the
original show both the original and ref so the test is still easy to understand
if you just load it up in a browser. If the test describes correctness, and the
ref-test aspect is “just for the computer” that’s one thing, but please
remember we want these tests to be easy to understand on their own in a web
browser as well.