[webkit-reviews] review denied: [Bug 73733] Inline RenderObject::view() : [Attachment 117737] Proposed inlining, moved the method to RenderView.h

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 73733: Inline RenderObject::view()
https://bugs.webkit.org/show_bug.cgi?id=73733

Attachment 117737: Proposed inlining, moved the method to RenderView.h
https://bugs.webkit.org/attachment.cgi?id=117737&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=117737&action=review


Concept is great.

The .exp file needs to be updated to avoid breaking the Mac build.

> Source/WebCore/rendering/RenderObject.h:517
> +    // Inlined into RenderView for performance and to avoid a cyclic
dependency.

This comment is confusing as written. I don’t know what it means to “inline
something into RenderView”. Maybe if you said RenderView.h it’d be easier to
understand.