[webkit-reviews] review granted: [Bug 73649] [Chromium] [WebSocket] Add binary support in echo test server : [Attachment 117612] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Takashi Toyoshima
<toyoshim at chromium.org>'s request for review:
Bug 73649: [Chromium] [WebSocket] Add binary support in echo test server
https://bugs.webkit.org/show_bug.cgi?id=73649

Attachment 117612: Patch
https://bugs.webkit.org/attachment.cgi?id=117612&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=117612&action=review


Seems reasonable.

>>> LayoutTests/http/tests/websocket/tests/hybi/echo_wsh.py:1
>>> +# Copyright 2009, 2011, Google Inc.
>> 
>> Just replace the old year to the new one instead of appending.
>> 
>> (I assume Chromium's copyright year rule applies here as well:
http://dev.chromium.org/developers/coding-style#TOC-File-headers)
> 
> Another reviewer suggest me adding new year instead of replacing one as a
WebKit style.
> Any guideline to know which file follows which rule?

It doesn't matter. :)  Anyone who feels it matters should fix
check-webkit-style to enforce one or the other. :)  Until then, I would tell
you not to worry about it.