[webkit-reviews] review denied: [Bug 73744] [GTK] Bad text rendering since r101343 : [Attachment 117760] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Dec 3 09:07:03 PST 2011


Martin Robinson <mrobinson at webkit.org> has denied Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 73744: [GTK] Bad text rendering since r101343
https://bugs.webkit.org/show_bug.cgi?id=73744

Attachment 117760: proposed patch
https://bugs.webkit.org/attachment.cgi?id=117760&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=117760&action=review


Looks good to me, but you'll also need to make this change in WebKit2.

> Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:159
> +    if (GdkScreen* screen = gdk_screen_get_default()) {

You should probably ASSERT screen and screenOptions here instead of using an
if.


More information about the webkit-reviews mailing list