[webkit-reviews] review granted: [Bug 73742] Rename CSSPrimitiveValueCache to CSSValuePool. : [Attachment 117755] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Dec 3 08:16:52 PST 2011


Antti Koivisto <koivisto at iki.fi> has granted Andreas Kling <kling at webkit.org>'s
request for review:
Bug 73742: Rename CSSPrimitiveValueCache to CSSValuePool.
https://bugs.webkit.org/show_bug.cgi?id=73742

Attachment 117755: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=117755&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=117755&action=review


r=me

> Source/WebCore/css/CSSValuePool.h:53
> +    typedef HashMap<int, RefPtr<CSSPrimitiveValue> > IdentifierValueCache;
> +    IdentifierValueCache m_identifierValueCache;
> +
> +    typedef HashMap<unsigned, RefPtr<CSSPrimitiveValue> > ColorValueCache;
> +    ColorValueCache m_colorValueCache;

These should be renamed too at some point.


More information about the webkit-reviews mailing list