[webkit-reviews] review requested: [Bug 72589] [GTK] Expose accessibility hierarchy in WebKit2 to ATK/AT-SPI based ATs : [Attachment 117752] Patch proposal

[bugzilla-daemon at webkit.org]

Mario Sanchez Prada <msanchez at igalia.com> has asked  for review:
Bug 72589: [GTK] Expose accessibility hierarchy in WebKit2 to ATK/AT-SPI based
ATs
https://bugs.webkit.org/show_bug.cgi?id=72589

Attachment 117752: Patch proposal
https://bugs.webkit.org/attachment.cgi?id=117752&action=review

------- Additional Comments from Mario Sanchez Prada <msanchez at igalia.com>
So here it comes the first temptative patch, including:

  - The code needed to plug the a11y hierarchies in the UI and Web processes as
if it was just one (from the POV of ATs like Orca)
  - New accessibility unit test for WK2, with all the needed infrastructure to
test this thing (mainly a helper process running a simple WebKitView + the
actual test inspecting that helper process through ATSPI)
  - New dependency added (required for the unit test): ATSPI2
  - Some changes in the run-gtk-test script, so it makes sure that the
accessibility support is available before running the tests

Just one little last thing: in order to be able to get this new unit test
running properly, you need to make sure that you have installed both
at-spi2-core and the at-spi2 ATK bridge (called at-spi2-atk in some systems,
and libatk-adaptor in others). If you have that, and were able to build the
patch (which means you have libatspi2.0-dev installed too), run-gtk-test should
be able to do all the rest of the magic.

Of course, this initial patch doesn't intend to be 100% feature complete,
bug-free or the like... but an initial -yet good-enough- first step to iterate
from, in order to provide proper accessibility support in WebKit2GTK.

That's it... for now